search

elliotcm / generic_form_builder

A generic Rails 3/4/5? form builder
5 stars 11 forks source link

check_box signature not compatible with rails #15

Open Davidslv opened 6 years ago

Davidslv commented 6 years ago

Hello,

Your check_box method doesn't follow the same signature as the rails one.

What this means is that even if I wanted to use the default_builder I wouldn't be able to

https://github.com/elliotcm/generic_form_builder/blob/533e7da4525fee245962562e715ce415c50a5b4c/lib/generic_form_builder.rb#L55

elliotcm commented 6 years ago

Gotcha. Submit a PR and I'll take a look.

Davidslv commented 6 years ago

@elliotcm #16 :)

Davidslv commented 6 years ago

I had to close the PR as it wouldn't take care of all the issues. I think this gem needs a better way to be overriden when necessary