removed escaping from the note content so we can style them with HTML

elliotcm / generic_form_builder

A generic Rails 3/4/5? form builder

5 stars 11 forks source link

removed escaping from the note content so we can style them with HTML #8

Closed pixelthing closed 10 years ago

pixelthing commented 12 years ago

ello Elliot - just a small tweak to your generic form builder, Alex wanted some line-breaks in the notes, and rather than jump back to the default builder and adding labels and notes separately, I thought I'd try and change it at source.

Hope things are good there...

elliotcm commented 11 years ago

Holy shit was this 11 months ago?

I held off merging it at the time because I was a little concerned about allowing potentially unsafe HTML through by default and didn't have time to check over the code properly.

Perhaps it should default to escaped but pass through an option?

elliotcm commented 10 years ago

If there's no longer a pressing need for this I'm going to close it. Less unescaped HTML the better.