search

elliotf / heekscnc

Automatically exported from code.google.com/p/heekscnc
Other
1 stars 0 forks source link

Profile start and end point no longer working in v0.17.1 #290

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
A file created in v 0.15 with specified start and end points for the profile 
operation doesn't work in 0.17.1.

The generated python code is different in the following way:

Code out of 0.17.1:
kurve_funcs.make_smaller( curve, start = area.Point(0.37, -0.08), finish = 
area.Point(0.36, -0.07))
roll_on = 'auto'
roll_off = 'auto'
kurve_funcs.clear_tags()
kurve_funcs.add_tag(area.Point(-0.07, 3.28), 0, 0.7853981634, 0.2)
kurve_funcs.add_tag(area.Point(-0.1, 1.51), 0, 0.7853981634, 0.2)
kurve_funcs.add_tag(area.Point(5.59, 1.37), 0, 0.7853981634, 0.2)
kurve_funcs.add_tag(area.Point(5.57, 3.4), 0, 0.7853981634, 0.2)
kurve_funcs.profile(curve, 'right', tool_diameter/2, offset_extra, roll_radius, 
roll_on, roll_off, rapid_down_to_height, clearance, start_depth, step_down, 
final_depth)

Working code out of v0.15 (ish)
kurve_funcs.make_smaller( k10, startx = 0.37, starty = -0.08, finishx = 0.36, 
finishy = -0.07)
roll_on = 'auto'
roll_off = 'auto'
kurve_funcs.clear_tags()
kurve_funcs.add_tag(-0.07, 3.28, 0, 0.7853981634, 0.2)
kurve_funcs.add_tag(-0.1, 1.51, 0, 0.7853981634, 0.2)
kurve_funcs.add_tag(5.59, 1.37, 0, 0.7853981634, 0.2)
kurve_funcs.add_tag(5.57, 3.4, 0, 0.7853981634, 0.2)
kurve_funcs.profile(k10, 'right', tool_diameter/2, offset_extra, roll_radius, 
roll_on, roll_off, rapid_down_to_height, clearance, start_depth, step_down, 
final_depth)

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by filipmul...@q.com on 27 Feb 2011 at 12:54

GoogleCodeExporter commented 8 years ago 
I created a sample file (inch units) showing the problem.  It looks like it 
might be something in how the python kurve_funcs is called or in that library 
code, since if I try to make the python script look like the old call, that 
doesn't work either...

Original comment by filipmul...@q.com on 27 Feb 2011 at 1:44

Attachments:

GoogleCodeExporter commented 8 years ago 
I have repeated this problem. In kurve_funcs.py, in make_smaller, 
curve.ChangeStart and curve.ChangeEnd were expecting a point exactly on the 
curve. I have fixed this by changing the python code to this 
"curve.ChangeStart(curve.NearestPoint(start))".
Also, curve.ChangeEnd wasn't working correctly. I have fixed this in the "area" 
module.

Original comment by danhe...@gmail.com on 28 Feb 2011 at 10:00

GoogleCodeExporter commented 8 years ago 
It looks like the end point works again now, but the start point still seems to 
have a problem.  It looks like it's not finding the nearest point on the curve 
for the start.  It seems to find the nearest vertex to my rectangle to start.  
See attached file.

Original comment by filipmul...@q.com on 1 Mar 2011 at 3:53

Attachments: