search

elliotgao2 / gain

Web crawling framework based on asyncio.
GNU General Public License v3.0
2.04k stars 207 forks source link

Gain Improvements - Stable #50

Closed kwuite closed 5 years ago

kwuite commented 5 years ago

I want to resolve #42, #43, #46, #49

I disabled the cache test since we'd need to update ci and start webserver.py somehow and ensure redis is available as wel.

Gladly hear your thoughts on this so I can make a separate PR for improving tests.

Please review and update PyPi after acceptance.

kwuite commented 5 years ago

Removed python 3.7 test. Seems not to be supported by travis.

kwuite commented 5 years ago

Almost done with redis cache test please wait with merge until I completed it so we have test coverage on a very important part of the new code.

kwuite commented 5 years ago

Repo can be squashed. Redis cache tests have been implemented. Removed python 3.5 support since async coding on 3.6 and 3.7 is much cleaner and supporting python 3.5 will be a pain and feels quite unnecessary.

kwuite commented 5 years ago

@gaojiuli, are you still available for review and merge?

kwuite commented 5 years ago

@gaojiuli, are you still available for review and merge?

Would really like to know if you are stil moving on with this library.

kwuite commented 5 years ago

Least you could do is respond. Closing PR. Next time don't publish something if you do not intend to maintain or respond to it.