Fix missing enumerate() in btree.py's bitmap handling code.

elliotnunn / machfs

Library for reading and writing Macintosh HFS volumes

https://pypi.org/project/machfs/

MIT License

51 stars 5 forks source link

Fix missing enumerate() in btree.py's bitmap handling code. #1

Closed sfuller closed 3 years ago

sfuller commented 3 years ago

Thanks for this awesome library! I found this bug while assembling a ton of files from The Macintosh Garden into some hfs volumes using machfs.

elliotnunn commented 3 years ago

Good find! How does this bug manifest?

sfuller commented 3 years ago

It manifests when there are enough btree nodes where additional bitmap nodes are needed. (>=2048 nodes) Otherwise mapnodes is never appended to and remains an empty list.

elliotnunn commented 3 years ago

Merged for the new point release: https://pypi.org/project/machfs/1.3/

Thank you. Those must have been some big volumes.