Closed marinkobabic closed 10 years ago
Thanks for the pull request Marinko. Just for my sanity could you (rightly or wrongly) try and stick to NES' code conventions e.g. no regions, directives outside namespaces, no comments for the sake of comments etc
This means you need a new pull request without ony style resp. NES style?
Von Samsung Mobile gesendet
-------- Ursprüngliche Nachricht -------- Von: Elliot Ritchie notifications@github.com Datum:20.07.2014 13:26 (GMT+01:00) An: elliotritchie/NES NES@noreply.github.com Cc: Marinko marinko.babic@ruf.ch Betreff: Re: [NES] V5 (#28)
Thanks for the pull request Marinko. Just for my sanity could you (rightly or wrongly) try and stick to NES' code conventions e.g. no regions, directives outside namespaces, no comments for the sake of comments etc
— Reply to this email directly or view it on GitHub.
It seems like code without any comments makes sense to you. I do not agree, but I will change the code to your style and make a new pull request
Hi Elliot
Here the list of the changes I have made:
Please check the changes and create a prerelease package of NES, so that I can test the newest version. There are some conceptual thinks we need to talk about, but it has no priority.
Thanks Marinko