search

elliots / protoc-gen-twirp_swagger

Swagger generator for twirp
Other
62 stars 15 forks source link

build failed via `go get` #13

Closed ziyi-yan closed 5 years ago

ziyi-yan commented 5 years ago 
~ $ go get github.com/elliots/protoc-gen-twirp_swagger
# github.com/elliots/protoc-gen-twirp_swagger/genswagger
go/src/github.com/elliots/protoc-gen-twirp_swagger/genswagger/template.go:534:105: reg.GetUseFQNForSwaggerName undefined (type *"github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/descriptor".Registry has no field or method GetUseFQNForSwaggerName)
ziyi-yan commented 5 years ago

It seems introduced by the most recent PR #12. Could you please take a look? @marwan-at-work

marwan-at-work commented 5 years ago

@ziyi-yan did you set GO111MODULE=on? Since you're downloading a binary, your project doesn't have to use Go Modules, but you can still use it to download binaries (Go 1.12+)

It seems to work for me: 

GO111MODULE=on go get github.com/elliots/protoc-gen-twirp_swagger@latest
go: finding github.com/elliots/protoc-gen-twirp_swagger latest
go: downloading github.com/elliots/protoc-gen-twirp_swagger v0.0.0-20190707132119-fda01df7c6eb
go: extracting github.com/elliots/protoc-gen-twirp_swagger v0.0.0-20190707132119-fda01df7c6eb
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/golang/protobuf v1.3.1
go: downloading github.com/grpc-ecosystem/grpc-gateway v1.9.3
go: extracting github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: extracting github.com/golang/protobuf v1.3.1
go: extracting github.com/grpc-ecosystem/grpc-gateway v1.9.3
go: downloading github.com/ghodss/yaml v1.0.0
go: downloading google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8
go: extracting github.com/ghodss/yaml v1.0.0
go: downloading gopkg.in/yaml.v2 v2.0.0-20170812160011-eb3733d160e7
go: extracting gopkg.in/yaml.v2 v2.0.0-20170812160011-eb3733d160e7
go: extracting google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8
go: finding github.com/golang/protobuf v1.3.1
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding gopkg.in/yaml.v2 v2.0.0-20170812160011-eb3733d160e7
go: finding github.com/ghodss/yaml v1.0.0
go: finding github.com/grpc-ecosystem/grpc-gateway v1.9.3
go: finding google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8
marwan-at-work commented 5 years ago

@ziyi-yan let me know if the above solves your build, otherwise feel free to re-open this issue.