Update template.go - Githubissues

elliots / protoc-gen-twirp_swagger

Swagger generator for twirp

Other

62 stars 15 forks source link

Update template.go #21

Closed titpetric closed 4 years ago

titpetric commented 4 years ago

Closes #20

int64 is a valid javascript integer type
uint64 is an integer type, but it doesn't have a defined format as per spec (https://swagger.io/docs/specification/data-models/data-types/)

I'm aware that the Swagger spec (or JS runtimes) don't support uint64, but as far as the spec goes, encoding shouldn't be "coalesced" to a string type. I just dropped the "format", as it's undefined behavior.

titpetric commented 4 years ago

My god. Encoding/json isn't wire compatible with PB json. The generator is factually correct as long as you use the grpc/jsonpb encoder/decoder. :facepalm: