search

elliotstokes / gpx-parse

GPX parser
MIT License
44 stars 40 forks source link

Parse time from track points, if any #2

Closed stensrud closed 10 years ago

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.61%) when pulling 4d00f627ec0a69c698f898faf703af67da50a9a9 on stensrud:master into efa2883b2433b9a6d7c3abe8cbe572dd08b61b24 on elliotstokes:master.

elliotstokes commented 10 years ago

Thanks for this. Any chance you could just add a test for this or modify one of the existing tests. I'll merge it then.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.61%) when pulling bc7ec08c3cc968d66506e5295479fbb83d9b3076 on stensrud:master into efa2883b2433b9a6d7c3abe8cbe572dd08b61b24 on elliotstokes:master.

stensrud commented 10 years ago

Updated the test. However, I'm not exactly sure why the date in the parsed result is a string and not a Date-object (no getTime()-function on it), since gpxWaypoint creates a Date-object.

elliotstokes commented 10 years ago

It should probably work like the waypoint class. I just had a look and it is constructing the date in the constructor. Maybe have the date working like that? Thanks

Elliot

elliotstokes commented 10 years ago

Will update to use date object after merge. Thanks for your pull request.