search

elliotstokes / gpx-parse

GPX parser
MIT License
44 stars 40 forks source link

Fix calculateMidpoint #20

Closed pavloDeshko closed 7 years ago

pavloDeshko commented 7 years ago

  1. Fixed and completed calculateMidpoint(), so it returns correct result as [ lat, lon ] Array. I think its better than {lat: lat, lon: lon}, which can be confused with full-blown GpxWaypoint Object

  2. Added optional inMiles parameter to calculateDistance(). Great Circle in miles is there for a reason, I guess :)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 97.26% when pulling 05d84a065d2d4d1bbcd968020e992dea6b22341b on pavloDeshko:patch-1 into 8363e3f4728206f24f87ce06c768408fd035a1bd on elliotstokes:master.

elliotstokes commented 7 years ago

Sorry its been a while - Ive been off doing other things. Cheers for this! Ill take a look and get this merged in asap