elliotstokes / gpx-parse

GPX parser
MIT License
44 stars 40 forks source link

Add rest of Waypoint schema elements + tests #27

Closed thmsdnnr closed 4 years ago

thmsdnnr commented 6 years ago

things added+fixed

  1. I added cmt to the Waypoint creation step in gpxParse so that a comment in the waypoint XML is associated with the new GpxWaypoint.
  2. I added the missing Waypoint elements per these docs and added support to the parser for V1.0 and V1.1 GPX parsing. I also added support for the Links field — please make sure it is implemented how you envision it. Now it returns an empty array [] if no links are present, else an array of objects with keys src, text, type. It allows for missing values for any of these fields, returning in this case an empty string "".
  3. I added tests for v1.0, v1.1, and object-tests to cover the new code.

oops

I squashed commits from the previous PR and filed a new one to clean things up, hence the slight duplication. Sorry about the git messiness.

closes #25