elliottslaughter / integrity-checker

Backup integrity checker
Apache License 2.0
21 stars 2 forks source link

version information missing #4

Closed CristianCantoro closed 3 years ago

CristianCantoro commented 4 years ago

The --versionis not displaying any version number

$ ick --version
Integrity Checker 
$ ick build --version
ick-build 
elliottslaughter commented 4 years ago

Yes, I see that. It seems to be an issue when installing from crates.io. When you build locally it has the right version:

$ ick --version
Integrity Checker 
$ cargo run -- --version
    Finished dev [unoptimized + debuginfo] target(s) in 0.43s
     Running `target/debug/ick --version`
Integrity Checker 0.1.0

My guess is we may be looking at a clap bug here, since all we're doing is calling clap::clap_version!. According to the documentation, this version comes out of Cargo.toml, and I don't see any reason why that wouldn't get packaged with crates.io (in fact, it wouldn't build without that file).

elliottslaughter commented 3 years ago

This seems to have been fixed some time ago upstream in clap. I will try to do a release soonish to capture this, in the meantime you can always install via Git:

cargo install --git https://github.com/elliottslaughter/integrity-checker.git
CristianCantoro commented 3 years ago

@elliottslaughter wrote:

This seems to have been fixed some time ago upstream in clap. I will try to do a release soonish to capture this, in the meantime you can always install via Git:

I confirm that installing via git fixes this issue:

$ ick -V
Integrity Checker 0.2.1
elliottslaughter commented 3 years ago

I pushed this to crates.io so users should get it with cargo install integrity-checker now.