Add Docker Compose and required images

[Celant]

Added the docker-compose.yml file and all the related images needed to spin up a working version of the site, including memcached. Images use the Laradock Docker images as upstreams

[Byorun]

I may be wrong, I don't know docker but shouldn't this also "install" the application itself? (composer install, etc...)

[Celant]

Yep, you're totally right, I forgot to add that part to the commit! Apologies, will do that once I'm back near my computer.

[razzeee]

Any news on this? Would be quiet handy for developing.

[sorianog]

@Razzeee This would definitely help me. Memcached is one of the obstacles preventing me from running a local version of the site.

[beatsaver]

Memcache is like the easiest thing in the world to install, stop being lazy

On Sun, Sep 9, 2018, 6:17 PM Gerald S notifications@github.com wrote:

@Razzeee https://github.com/Razzeee This would definitely help me. Memcached is one of the obstacles preventing me from running a local version of the site.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Byorun/beatsaver-laravel/pull/19#issuecomment-419749085, or mute the thread https://github.com/notifications/unsubscribe-auth/AlqNKeWsYoH8lRn8cKnIVtXenOIF3ubMks5uZZOSgaJpZM4WKSM5 .

[sorianog]

@beatsaver What OS did you install it on? Tried at least 2 times, 2 different methods on Windows with no success. Did not want to spend 2 hours to get it to run locally...

[beatsaver]

Ubuntu 1804 only I suggest if you have Windows 10 to install the Linux subsystem for Windows or run it inside of a virtual machine

On Sun, Sep 9, 2018, 6:50 PM Gerald S notifications@github.com wrote:

@beatsaver https://github.com/beatsaver What OS did you install it on? Tried at least 2 times, 2 different methods on Windows with no success. Did not want to spend 2 hours to get it to run locally...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Byorun/beatsaver-laravel/pull/19#issuecomment-419750859, or mute the thread https://github.com/notifications/unsubscribe-auth/AlqNKR_m6h30KBO8PljAFq44fbfZC4JUks5uZZtIgaJpZM4WKSM5 .

[Byorun]

For the record I am developing on windows subsystem linux with mysql and memcache installed on ubuntu 1804

[Celant]

Hey all. @Byorun I just re-read the commit, and I didn't forget. It seems automating the composer install wasn't particularly trivial, so as a stop-gap fix the readme contains the instructions on how to run composer install. I think automating that is slightly out of the scope of this PR, as it'll take some time to do. As far as I can see, this should be ready to merge. If @Razzeee or @sorianog want to test it too, that'd be useful.

[razzeee]

I tried to run it yesterday and realized that docker requires windows pro... Will have to figure something out for that, as running memcached doesn't seem practial on windows...

So I will have to try at work, but that's a different problem as I needed to disable Hpyer-V due to problems. So please don't wait for my approval before merging this.

[beatsaver]

you should just use a virtual machine or run the linux subsystem, as that will run memcache just fine

On Mon, Sep 17, 2018 at 9:30 AM, Razzeee notifications@github.com wrote:

I tried to run it yesterday and realized that docker requires windows pro... Will have to figure something out for that, as running memcached doesn't seem practial on windows...

So I will have to try at work, but that's a different problem as I needed to disable Hpyer-V due to problems. So please don't wait for my approval before merging this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Byorun/beatsaver-laravel/pull/19#issuecomment-422016536, or mute the thread https://github.com/notifications/unsubscribe-auth/AlqNKbAjC0Wyz2694tVW3ZUaibcaD39uks5ub6PngaJpZM4WKSM5 .

[sorianog]

Hey all,

Just got myself a MacBook so I'll see if I have better luck with actually standing up the site for testing! :)

On Mon, Sep 17, 2018, 9:21 AM Celant notifications@github.com wrote:

Hey all. @Byorun https://github.com/Byorun I just re-read the commit, and I didn't forget. It seems automating the composer install wasn't particularly trivial, so as a stop-gap fix the readme contains the instructions on how to run composer install. I think automating that is slightly out of the scope of this PR, as it'll take some time to do. As far as I can see, this should be ready to merge. If @Razzeee https://github.com/Razzeee or @sorianog https://github.com/sorianog want to test it too, that'd be useful.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Byorun/beatsaver-laravel/pull/19#issuecomment-422010743, or mute the thread https://github.com/notifications/unsubscribe-auth/AMpbj4ITPtTVCq6jEZHift3QkBK2b4C0ks5ub6BNgaJpZM4WKSM5 .

[razzeee]

After looking back at this and remembering the other stuff I did in laravel I think we should use homestead instead of docker.

https://laravel.com/docs/5.7/homestead#introduction

I would prepare a pr if we can agree on this.

[Byorun]

@Razzeee you can do that, but keep in mind that we are still using Laravel 5.6. So if there is something special regarding homestead and 5.7 it might not work with 5.6

[Celant]

Regardless of the use of Homestead or not, Docker can still be useful. Devs seem to prefer Docker more, and Docker can be used for production deployments too, unlike Homestead. Both would be good :)

[razzeee]

yes, very useful for production build, but not sure if it's worth it if the person hosting the site is not using/planning to use docker to deploy.

[luludotdev]

This isn't really helpful since Docker isn't being used in prod.