search

elliotttate / beatsaver-laravel

Rewrite of beatsaver.com (https://github.com/beatsaver/beatsaver) using the laravel framework
https://discord.gg/8B44zqM
MIT License
39 stars 19 forks source link

Song Previews #44

Closed luludotdev closed 6 years ago

luludotdev commented 6 years ago

Closes #42 Loads the song zip, extracts it in-browser, and plays the song preview.

Added new buttons to the song preview and detail blades to start/stop previews. Starting a preview for a song while one is already playing will stop the current preview and reset the other button.

The button shows a loading indicator while the browser loads the song into memory, and switches to Stop Preview when it starts playing.

NOTE

This is only done in the Bulma theme, feel free to backport it to Bootstrap if you like.

luludotdev commented 6 years ago

Another problem with the preview system is that it adds to the download counter of the song when you preview, since it has to download the song .zip to load the .ogg

A potential solution to this would be to implement a separate download endpoint that does not track downloads.

beatsaver commented 6 years ago

I suggest editing this to bypass the download URL and use the ID information to point directly to the ZIP file, if you look its the same format at the ID system

beatsaver commented 6 years ago

I will modify to use the api details to infer the zip path