search

elliotttf / semantic-release-conventional-commits

Semantic release commit analyzer support for all of the conventional commit message types
12 stars 1 forks source link

! after the type/scope does not trigger a major release #18

Closed DanySK closed 2 years ago

DanySK commented 2 years ago

I am trying this plugin, and I tested with the following commit message:

ci(deps)!: inherit the configuration for docker images

which resulted in:

[18:22:09] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "semantic-release-conventional-commits"
[18:22:09] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "semantic-release-conventional-commits"
[18:22:09] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

While the conventional commits specification says:

BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.

Changing the commit message by adding a footer starting with BREAKING CHANGE: achieved the expected behaviour instead. However, at the moment I believe that this plugin does not follow the semantic-release-conventional-commits specifcation.

elliotttf commented 2 years ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: