search

elliotwaite / thumbnail-rating-bar-for-youtube

A Chrome and Firefox extension for YouTube that adds a rating bar (likes/dislikes ratio) to the bottom of every thumbnail.
https://chrome.google.com/webstore/detail/youtube-thumbnail-rating/cmlddjbnoehmihdmfhaacemlpgfbpoeb
MIT License
250 stars 15 forks source link

Error in manifest file #14

Closed Gitoffthelawn closed 5 years ago

Gitoffthelawn commented 5 years ago

If you go to about:debugging in Firefox, this extension causes the following warning/error:

Reading manifest: Error processing background.persistent: Event pages are not currently supported. This will run as a persistent background page.

Does this warrant an update?

elliotwaite commented 5 years ago

Fixed (in the latest release, version 0.0.41). I made the background script persistent since nonpersistent background scripts aren't supported in Firefox yet.

Thanks for reporting this!

Gitoffthelawn commented 5 years ago

You're welcome, and thank you!

Gitoffthelawn commented 5 years ago

BTW, would it be a good idea for you to set up a to-do item to make it nonpersistent when FF supports it in the future?

elliotwaite commented 5 years ago

Good idea. I've added a TODO comment in the code (https://github.com/elliotwaite/thumbnail-rating-bar-for-youtube/blob/master/tools/build_package.py#L30). Is that what you were suggesting, or is there another way to create to-do items on GitHub that I don't know about?

Gitoffthelawn commented 5 years ago

That's exactly what I was thinking, along with a GitHub issue report with one or two tags, such as future and firefox. That way it can stay open, but you (and others) can see the tags.

elliotwaite commented 5 years ago

Gotcha, good idea. I've opened a new issue about it. Thanks for the tips.