search

elliotwaite / thumbnail-rating-bar-for-youtube

A Chrome and Firefox extension for YouTube that adds a rating bar (likes/dislikes ratio) to the bottom of every thumbnail.
https://chrome.google.com/webstore/detail/youtube-thumbnail-rating/cmlddjbnoehmihdmfhaacemlpgfbpoeb
MIT License
250 stars 15 forks source link

Use browser option UI for settings #28

Closed Jackymancs4 closed 4 years ago

Jackymancs4 commented 4 years ago

Hello @elliotwaite This PR allow the user to interact with the settings also using the UI defined by the browser. It is useful to me because I can hide the browser_action button (to declutter the bar) while still being able to easily tweak the settings if I feel like to.

It is my opinion that the browser_action key could be removed entirely because it is not semantically correct to use it for settings, but this is very minor issue.

For documentation https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_ui

Thanks!

elliotwaite commented 4 years ago

Sorry for the delay in reply. Thank you for these changes! Good suggestions. I'll put them in the next release, which I'll probably publish in the next few days.

elliotwaite commented 4 years ago

This update has been released (version 1.0.1). Thanks again for the contribution!