elliotwaite / thumbnail-rating-bar-for-youtube

A Chrome and Firefox extension for YouTube that adds a rating bar (likes/dislikes ratio) to the bottom of every thumbnail.
https://chrome.google.com/webstore/detail/youtube-thumbnail-rating/cmlddjbnoehmihdmfhaacemlpgfbpoeb
MIT License
249 stars 17 forks source link

[Request+bug] colour-coded percentage rating - choose a colour of the font #40

Closed tofik7 closed 3 years ago

tofik7 commented 3 years ago

Hi everyone,

I am very happy user of your addon for Chrome, thanks for this!

I would like to ask if this would be possible to add an option for "colour-coded percentage rating feature" which would allow us to select own colour of the font?

The green one is not really visible IMHO, please check screenshot attached, 2021-04-21_124847

also I think there is a bug with rating bar when we use a green+red bar, please look at the picture attached (zoomed), over the rating bar we have very thin red line as I marked on the photo, I need to say it is not present in every video, only for some of them (check photo above) 2021-04-21_131510

thanks

elliotwaite commented 3 years ago

Thanks for the suggestion. I originally decided on the text colors while using the dark theme mode and I didn't realize until later that they looked too bright when in the light theme mode, so thanks for encouraging me to fix this. I have just released an update (version 1.3.4) that darkens the brightness of the green colors when in light theme mode.

At the moment, I would prefer to just get the default text colors to look good rather than adding an option to customize the ratingToRgb() function, since that would be pretty complicated and I'm not sure if it would offer much benefit. So let me know if the update to the default colors is a good enough solution for you.

About the thin red line above the rating bar, I was unable to reproduce this issue. Can you give me some more details about how I can reproduce this bug? Which browser and operating system are you using? Which URL are you viewing? Are you using any non-default zoom settings in the browser (sometimes using zoom settings other than 100% can cause elements to not align properly)?

tofik7 commented 3 years ago

Thanks for your answer and effort, I really appreciate it,

I think it looks much better now (the brightness of the green colors), thanks!

About the thin red line above the rating bar, please find below some more details from my setup:

If you need any more info, please let me know,

elliotwaite commented 3 years ago

Does the issue go away when you change the "Scale and layout" percentage to 100%?

tofik7 commented 3 years ago

I just checked and yes, "Scale and layout" set to 100% and there is no problem, going back to 125% and red line is back there.

elliotwaite commented 3 years ago

I just released an update (version 1.3.5) that may fix this issue. I changed the rating bar HTML elements from being layered to being positioned side-by-side, so they should now display correctly even if there are some slight scaling inconsistencies between the parent and child elements. Let me know if this resolves this issue for you.

tofik7 commented 3 years ago

It's all good now, thank you very much for your effort here, really appreciate it!