search

elliotwaite / thumbnail-rating-bar-for-youtube

A Chrome and Firefox extension for YouTube that adds a rating bar (likes/dislikes ratio) to the bottom of every thumbnail.
https://chrome.google.com/webstore/detail/youtube-thumbnail-rating/cmlddjbnoehmihdmfhaacemlpgfbpoeb
MIT License
249 stars 17 forks source link

[BUG] Hides the blue bar for some videos on YT #73

Closed ibehnam closed 2 years ago

ibehnam commented 2 years ago

As seen in the picture, the blue bar doesn't appear for all videos. I've seen this issue in search results and the recommended videos on the right.

image
elliotwaite commented 2 years ago

Thanks for reporting this. This is a known issue that usually results from hitting the rate limit of the Return YouTube Dislike API. I have a short explanation about it in the README here. You can usually try refreshing the page after about 5-15 seconds to retry retrieving the ratings for those videos, but I should really just update the extension to have it auto-retry failed requests on its own after a certain amount of time. I'll work on an update to add the auto-retry logic.

elliotwaite commented 2 years ago

I just released 1.8.3 which adds the auto-retry feature.

If an API request fails, it will sleep for 5 seconds and then retry the request. It will continue doing this for up to a max of 7 attempts for that thumbnail. After 7 attempts (~30 seconds) without success, a full page refresh would be required to retry retrieving the data for that thumbnail. Let me know if you think any of these settings should be changed.

Also, in my testing, it seemed like I was hitting the rate limit more than usual. So there might be something going on right now with the Return YouTube Dislike API server, not sure.

Let me know if this resolves this issue for you, or if you think there would be a better solution for this.

elliotwaite commented 2 years ago

I just updated the retry strategy in v1.8.5.

The problem with my initial strategy was that it would continue retrying to process failed thumbnails that had already been removed from the page.

In the new strategy, when an API request gets rate-limited (or fails for any other reason), it marks that thumbnail as being unprocessed and sets a timeout for 5-seconds later to retry processing any unprocessed thumbnails that are still visible on the page.

If a thumbnail cannot be successfully processed after 10 retries, it gives up on that thumbnail.

ibehnam commented 2 years ago

Hi, yes it has improved quite a bit. There are few videos for which the extension doesn't work, but about 90% of the time it's working.

elliotwaite commented 2 years ago

Okay, sounds good. If you have any examples of specific videos for which the rating bar never loads, I could take a look and try to fix those.