elliotwaite / thumbnail-rating-bar-for-youtube

A Chrome and Firefox extension for YouTube that adds a rating bar (likes/dislikes ratio) to the bottom of every thumbnail.
https://chrome.google.com/webstore/detail/youtube-thumbnail-rating/cmlddjbnoehmihdmfhaacemlpgfbpoeb
MIT License
250 stars 15 forks source link

Extension no longer allows customization? #91

Closed tsnicholas closed 7 months ago

tsnicholas commented 7 months ago

I don't know where else to report this, so I'll just report it here. I had the extension customized to show the green-red variant of the like/dislike ratio and for it to appear on the top of videos. Recently, it randomly reverted to using the default settings and whenever I change it and refresh the page, it doesn't change from the default settings anymore. Is this an intentional design choice going forward or a bug? I'm not sure, but I figured I might as well report it anyway.

elliotwaite commented 7 months ago

Thanks for reporting this. This is a bug. The customization settings should still work.

I am not able to reproduce this issue on my system (macOS and Chrome). What operating system and browser are you using?

Can you follow these steps and let me know what happens?

tsnicholas commented 7 months ago

I change the settings to my usual by setting the position to the top and setting the colors to green/red, and then and get prompted to refresh the page.

image

I refresh the page only to find out that it didn't change my settings at all. It's still on the bottom with the blue and gray bar rather the green and red one.

image

I check the menu again, and sure enough, it had simply reverted back to the default settings.

image

If this isn't happening for everyone, then I'm not sure what exactly happened to bug my client out or anything like that. It just sorta happened and then when I went to change the settings back to my preferred ones, it would do this same process.

elliotwaite commented 7 months ago

Hmm. If the settings are being saved, it looks like there is an issue with the data not being stored to the extensions storage. Can you try this:

  1. Go to Firefox's "Extensions" page, then click the settings icon button in the top right of the list of extensions, then choose the "Debug Add-ons" option.

    image
  2. Then click the "Inspect" button to the right of the "Thumbnail Rating Bar for YouTube™" extension.

    image
  3. Then under the "Storage" tab, expand the "Extension Storage" option on the left, then click the "moz-extension://4e911fe6-..." option.

    image

Do you see any data saved in there similar to the above image?

If you don't see any saved data in there, can you try keeping that inspection window open and then going back to a normal Firefox window, opening the extension settings and updating them again to see if the data shows up in the inspection window after saving the settings?

image

If you do see data in there, but it doesn't look correct (like maybe it's been corrupted somehow), maybe you can try deleting it and then retry saving the new extension settings again. To delete the current data, right-click the "moz-extension://4e911fe6-..." item in the left menu and choose the "Delete All" option:

image

Alternatively, if the above tests don't help. Maybe you could try:

tsnicholas commented 7 months ago

Well, I think I may or may not have found the problem based on this guide. When I went to check the extension storage as instructed, I'm greeted with no data at all that's being stored. No local storage, no cookies, nothing.

image

I checked the storage for other extensions too, like return dislike button as an example, and sure enough the storage was still there. So, the problem with storage being gone completely was exclusive to this one.

image

So, I guess I deleted the extension storage somehow? As far as I know, I'm using the latest version of Firefox so that shouldn't be an issue. Either way, I decided to uninstall the extension and restarting Firefox before reinstalling to make sure nothing is cached. Sure enough, the storage is back.

image

After changing my settings to the green/red bar on the top, it now works as intended after refreshing the page.

image

So it would appear that the problem was that something deleted the storage for the extension. I'm not sure what would cause this but at least it's working again. I'm only a student when it comes to programming, especially when it comes to web development, but after discovering this, perhaps you could add a check to see if the storage items exist before saving? Maybe that's a good idea, maybe it's not. Not sure. Anyway, I thank you for your help regardless.

elliotwaite commented 7 months ago

I'm glad to hear you got it working.

That's strange that the storage tab wasn't showing anything, I'm not sure what would have caused that. Maybe I'll figure out the reason eventually.

Thanks again for opening this issue, since others may run into the same thing. And it's good to know that uninstalling the extension, restarting the browser, and reinstalling the extension is a potential fix.