elliotwoods / ofxCanon

openFrameworks addon for control and capture from Canon DSLR's via the EDSDK
37 stars 11 forks source link

Disabled breaking call to api method EdsDeleteDirectoryItem #6

Closed novazembla closed 3 years ago

novazembla commented 4 years ago

Hello,

in the process of getting the code base run on EDSDK 13.12.1 I found that the call to EdsDeleteDirectoryItem caused havok. Once run it first blocked the camera for several seconds and then brought the liveview to halt.

I've checked the reference document the call should not be necessary when dealing with in memory calls. Removing/disabling the line should be save for all versions as the document did not mention any changes to previous versions.

Thanks!

elliotwoods commented 4 years ago

Hi there! Ok interesting. Which camera + OS were you testing with also?

elliotwoods commented 4 years ago

p.s. thank you for submitting

novazembla commented 4 years ago

I've tested it on Macos Catalina with a 250D. Tried it with and without SD card (made no difference).

Had to adjust a few other lines in utils.cpp to comment out removed properties like CASE_RETURN(kEdsPropID, JpegQuality); to compile it with the latest EDSDK.framework. But I don't think that this was the cause of the problem.