elliotwoods / ofxCvGui

Panel based GUI library with DOM-like features for openFrameworks

http://www.kimchiandchips.com

32 stars 10 forks source link

Hardcoded paths #15

Open borg opened 8 years ago

borg commented 8 years ago

Amazing work here Elliot.

Just found a lot of hardcoded paths to the addons folder. For a number of reasons people like me are keeping non-official addons in separate submodules and folders. I suspect for similar reasons you want to make your paths explicit and exact. I totally understand why, but maybe there is another preprocessor way of doing it if needed?

Using recursive search paths

include "ofxLiquidEvent.h"

obviously works instead of

include "../../../addons/ofxLiquidEvent/src/ofxLiquidEvent.h"

elliotwoods commented 8 years ago

hey!

Thanks for the kind words!

It definitely should be #include "ofxLiquidEvent.h" I can see a few examples where this is wrong: https://github.com/elliotwoods/ofxCvGui/search?l=cpp&q=addons&type=Code&utf8=%E2%9C%93

I've made some changes to ofxCvGui recently which need testing on multiple platforms and with other addons, so I'll change these paths too but it will be later this coming week before I push changes back online.

Be great to hear what you found useful or lacking in ofxCvGui.

elliotwoods commented 8 years ago

heya! i did a quick pass over to remove ../../../ style paths thanks for reporting