search

elliotwoods / ofxCvGui

Panel based GUI library with DOM-like features for openFrameworks
http://www.kimchiandchips.com
32 stars 10 forks source link

added keyRelease which did not work before #26

Closed antimodular closed 4 years ago

antimodular commented 4 years ago

as mentioned in this issue post keyRelease was not listened to. i think i fixed it.

https://github.com/elliotwoods/ofxCvGui/issues/25

elliotwoods commented 4 years ago

omg! finally somebody uses ofxCvGui!

this makes sense - i had an issue with keys sticking on ofxGrabCam when used through ofxCvGui

could you have a look through your changes in https://github.com/elliotwoods/ofxCvGui/pull/26/commits/c18cf1fd4bdefabcf374fe5b9bd48e500bf4d4e0 and check that there isn't something in there which shouldnt be in the PR? it seems there's a few unrelated things also, but maybe if you can add some comments i can figure it out from there

thank you tnank you!!

antimodular commented 4 years ago

in order to remove some of those unclean sections, i downloaded your addon again and only added my additions related to the keyRelease problem. Now my dev_keyRelease branch should be clean :)

elliotwoods commented 4 years ago

looks good to me!! thank you for taking the time to clean it up also