search

ellipsesynergie / api-response

Simple package to handle response properly in your API.
MIT License
377 stars 53 forks source link

IMPROVEMENT Add existing query params to pagination links #30

Closed richdynamix closed 8 years ago

richdynamix commented 8 years ago

This PR is to allow existing query params to be included within the pagination links.

At present a call to /api/v1/search/?query=test will return /api/v1/search/?page=2 as the next link of the pagination links.

This update will now set the next link to be /api/v1/search/?query=test&page=2 using the method outlined in the Fractal documentation.

maximebeaudoin commented 8 years ago

Thank you for you contribution, however you need to fix the failing test.

richdynamix commented 8 years ago

Hi @maximebeaudoin Sorry for the delay in getting back to you. I have pushed another update which resolves the failed tests.

richdynamix commented 8 years ago

Is there any update when this could get merged?

dominicmartineau commented 8 years ago

@richdynamix Maxime Beaudoin cannot be reach before next week. So, I'll check your improvement and merge it.

richdynamix commented 8 years ago

Thanks @dominicmartineau

dominicmartineau commented 8 years ago

@richdynamix Done!

maximebeaudoin commented 8 years ago

@dominicmartineau tag 0.12.3 can be create too.

dominicmartineau commented 8 years ago

@maximebeaudoin 👍

dominicmartineau commented 8 years ago

@maximebeaudoin @richdynamix Tag 0.12.3 done!