ellipsys / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
0 stars 0 forks source link

Enhancement: Subtitles positioning/scaling with slider #479

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hello,
would it be possible do add 2 sliders (maybe with visibility toggled on key 
press) to the GUI which would change position and scale of the subtitles? 
(send_command("sub_pos %f 1") and send_command("sub_scale %f 1") respectively).

I convinced someone to replace windows with linux, and he misses this feature 
most from the otherwise sufficient gnome-player. 

The change to the code should not be large. I have working prototype written in 
vala if you were interested.

Original issue reported on code.google.com by mic...@gmail.com on 26 Jan 2011 at 10:08

GoogleCodeExporter commented 9 years ago
I think this might best be done with some hotkeys... if you have 
recommendations for what values to do I could do something like

s/S  where small s makes the subtitle smaller and big S makes the subtitle 
bigger.. I would have to see what keys are available however.

Original comment by kdeko...@gmail.com on 26 Jan 2011 at 1:43

GoogleCodeExporter commented 9 years ago
In my copy of gnome-mplayer there are already keys for that: SHIFT+R/SHIFT+T 
for smaller/larger subtitles (but none for subtitle position).

But there are two issues:
1. as my friend reports, this key combination works "awfully slow". I think the 
reason is mplayer itself: for "sub_pos" the subtitle position changes 
immediately, but for "sub_scale" the subtitle is not redrawn - only the new 
subtitle is drawn with correct (new) size. I think this is something to report 
as a bug for mplayer.
2. if you had a slider, you could change the subtitle scale (and position) 
"immediately", i.e. as fast as you could slide the slider. With key presses, it 
could require lots of them. And what also matters, sliders give you visual 
feedback of what value is currently set.

So in summary, I think for former windows users it would be desired 
functionality (they are used to it), and for the rest of us those two sliders 
could be hidden by default.

Original comment by mic...@gmail.com on 26 Jan 2011 at 11:33

GoogleCodeExporter commented 9 years ago
I am attaching sample Vala source file, so you could test the idea. You need 
"mplayer" installed, and open a movie with subtitles.

Original comment by mic...@gmail.com on 26 Jan 2011 at 11:52

Attachments:

GoogleCodeExporter commented 9 years ago
I'm not sure I want to add a visual slider as it clutters in the interface. And 
one of the goals of this project is to Keep It Simple.

Original comment by kdeko...@gmail.com on 27 Jan 2011 at 12:04

GoogleCodeExporter commented 9 years ago
Actually, I tried to implement sub_pos and found that it does not work with ASS 
subtitles, which are an improvement over normal subtitles. So there are 
multiple things that need to be fixed in mplayer. I'll change b/B to move the 
subtitle position instead of the size.

Original comment by kdeko...@gmail.com on 27 Jan 2011 at 12:12

GoogleCodeExporter commented 9 years ago
That is why I wrote "maybe with visibility toggled on key press" - you could 
add a new vbox at top/bottom (or add a row in an existing one, if there is 
any), which would be hidden by default, and its visibility could be changed 
with a hot key. So no difference for those who dont't need it.

Original comment by mic...@gmail.com on 27 Jan 2011 at 12:12

GoogleCodeExporter commented 9 years ago
I have reported sub_scale bug upstream:

http://bugzilla.mplayerhq.hu/show_bug.cgi?id=1862

Maybe you could report also that sub_pos bug for ASS subtitles?

Original comment by mic...@gmail.com on 27 Jan 2011 at 12:17

GoogleCodeExporter commented 9 years ago

Original comment by kdeko...@gmail.com on 21 Feb 2011 at 6:05