search

ellismg / corefx

This repository contains the foundational libraries that make up the .NET Core development stack.
MIT License
0 stars 2 forks source link

add tests for number formatting #3

Closed steveharter closed 9 years ago

ellismg commented 9 years ago

Thanks for adding these tests, Steve. I think that we should move towards using [Theory] to remove duplication in the tests. I think long term we will need a better way to deal with the fact that the data differs between ICU and Windows. Maybe have the data passed to each theory include an expected ICU value and an expected Windows value and then use RuntimeInformation.IsOSPlatform(OSPlatform.Windows) to figure out which one to assert against?

steveharter commented 9 years ago

OK I wasn't aware of the Theory and RuntimeInformation.IsOSPlatform so I'll use that and send another PR. Thanks

ellismg commented 9 years ago

Looks good. I will merge this once we merge the corresponding changes into coreclr.