Broken highlight in coc.nvim hover popup

ellisonleao / gruvbox.nvim

Lua port of the most famous vim colorscheme

MIT License

1.91k stars 202 forks source link

Broken highlight in coc.nvim hover popup #123

Closed madlabman closed 2 years ago

madlabman commented 2 years ago

Breaking change introduced in 3352c12. See for brackets background at the bottom screenshot.

Before:

After:

ellisonleao commented 2 years ago

hey @madlabman i just pushed a new config system with some fixes. Can you pull latest, and check if it's still having this issue please?

madlabman commented 2 years ago

@ellisonleao I've pulled the changes to c44d664 and on neovim-0.7.2-1 I see the same:

Look at the intent guides as well (it is in blue now).

P.S. What I noticed: neovim-0.7.0-3 works ok, and on later versions, especially on 0.7.2-1 black background as reported.

ellisonleao commented 2 years ago

@madlabman I've tested this issue with other color schemes and it seems like it is an issue in neovim itself, but I couldn't find the gh issue for it yet.

madlabman commented 2 years ago

@ellisonleao interesting, but I see no issue with sainnhe/everforest theme using neovim 0.7.2-3.

ellisonleao commented 2 years ago

hey, @madlabman I just pushed a possible fix for it. Can you pull the latest and confirm, please? I've tested in some builtin lsp diagnostic floating windows for both colorschemes:

light: Screenshot from 2022-07-14 18-33-01

dark:

Screenshot from 2022-07-14 18-32-52

madlabman commented 2 years ago

@ellisonleao, I've pulled 1b8b7be and it works now