search

ellisp / forecastHybrid

Convenient functions for ensemble forecasts in R combining approaches from the {forecast} package
GNU General Public License v3.0
79 stars 23 forks source link

Add Theta functionality. #55

Closed ellisp closed 7 years ago

ellisp commented 7 years ago

OK I think this is ready to come in. @dashaub do you want to have a close look?

I think CRAN checks will fail just now because of #54 which has crept in somehow as a problem in the README which I've made a formal test until we fix it. But I'm pretty sure that's unrelated to what I've been doing on theta.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.7%) to 96.703% when pulling 18f59e2badbdd9affdc06be1cef640088f6b79e4 on thetadev into 6ec1af3ab438f883f5e636778a7e8de86d373f64 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.7%) to 96.703% when pulling 18f59e2badbdd9affdc06be1cef640088f6b79e4 on thetadev into 6ec1af3ab438f883f5e636778a7e8de86d373f64 on master.

dashaub commented 7 years ago

@ellisp I'll take a look this weekend, sorry for the delay.

dashaub commented 7 years ago

@ellisp Looks good. The only issue I see is the PI for the nnetar forecasts, but it look like you already fixed that.