search

ellisp / forecastHybrid

Convenient functions for ensemble forecasts in R combining approaches from the {forecast} package
GNU General Public License v3.0
79 stars 23 forks source link

Computation of residuals #95

Closed philturk closed 4 years ago

philturk commented 4 years ago

Hi gentlemen:

Thank you for your package and your efforts here.

You should have look at your residuals from your "hybrid" model. In the vignette (and as I verified with a toy example), the fitted values and the residuals are identical. From your vignette, see:

head(fitted(hm1))
head(residuals(hm1))

So something is amiss.

Best,

-- Phil

dashaub commented 4 years ago

@philturk Thanks for the bug report. Fixed in e14758e0a1409ee30ad85d150df039b79bdbad44.