search

ellisw / simpleTwitterApp

0 stars 0 forks source link

[Android Bootcamp] Simple Twitter App Review #1

Open ellisw opened 10 years ago

ellisw commented 10 years ago

My app is ready for review. I didn't get a chance to persist data, but the other optional parts should be done.

I had a question about endless scrolling. Why does the page go back to the top of the list view when we get older tweets? Is there a way to make sure the list stays in the same position. /cc @nesquena @timothy1ee

nesquena commented 10 years ago

Ellis, :+1: nice work overall. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

I didn't get a chance to persist data, but the other optional parts should be done.

Great, you should try that next.

I had a question about endless scrolling. Why does the page go back to the top of the list view when we get older tweets? Is there a way to make sure the list stays in the same position.

This shouldn't be happening. This is happening because you are probably reinstantiating the adapter too often. You should only create the adapter and array once in onCreate. Subsequent content should simply either adapter.clear to clear out all or adapter.addAll to append content. If you properly apply this, you won't see that snapping to the top issue anymore.