search

ellmetha / django-machina

A Django forum engine for building powerful community driven websites.
https://django-machina.readthedocs.org
BSD 3-Clause "New" or "Revised" License
592 stars 126 forks source link

Allow get_class from apps.AppConfig #288

Closed BoPeng closed 1 year ago

BoPeng commented 1 year ago

https://github.com/ellmetha/django-machina/issues/229 https://github.com/ellmetha/django-machina/issues/287

Current, get_class does not support apps defined in INSTALLED_APPS as

INSTALLED_APPS = [
    ...
    "machina.forum_tracking.apps.ForumTrackingAppConfig",
    ...
]

This does not conform to django conventions and makes deriving from machina-defined AppConfig more difficult (see #287 for details).

This PR parses app and handles the apps case for get_class.

BoPeng commented 1 year ago

Tests for python 3.6 should be removed, I guess.

image
BoPeng commented 1 year ago

@ellmetha I think this PR is clean enough to be merged.

BoPeng commented 1 year ago

Test added.