search

ellraiser / love-build

zero-dependency cross-platform builder for LÖVE to export games to Windows, MacOS, and Linux
https://love2d.org
20 stars 4 forks source link

Building windows crashes for certain icon sizes #11

Open Endaris opened 1 day ago

Endaris commented 1 day ago

In love-exedit.lua in line 382, newdata which is FileData userdata is overwritten by a string if it turns out that the resized icon from the build config is bigger than lvl3_entry.DataSize. The application then crashes in line 386 because it tries to call FileData:getString on what is no longer FileData. Wrapping line 382 in a newFileData solves the crash but I have no immediate access to a Windows machine right now to confirm the exe icon is also correct afterwards so I'm opening an issue instead of a PR. Used icon for repro: icon

ellraiser commented 14 hours ago

Ah nice, will have a look - i know there's less space to play with now in 12 but should still be able to get it working