ellucian-developer / integration-sdk-csharp

C-Sharp framework for interacting with Ethos Integration.
MIT License
9 stars 4 forks source link

EncodeString() doesn't work for NamedQueryFilter methods #4

Open tone711 opened 4 days ago

tone711 commented 4 days ago

https://github.com/ellucian-developer/integration-sdk-csharp/blob/531987ff325326ecbee4084ceecb31cfc2354988/Ellucian.Ethos.Integration/Client/Proxy/EthosFilterQueryClient.cs#L1496

This function encodes the query string portion of the call to an Ethos endpoint. For query strings that begin with "?criteria=" it encodes everything after the equals (=) sign; for all other queries, the entire string is encoded.

Encoding the entire query string causes the call to return a 404 - "Resource owner not found for the requested resource" error.

A solution would be to encode all query strings after the equals (=) sign. If I find the time, I'll try to submit a working function.

tone711 commented 4 days ago

Proposed solution is here: https://github.com/tone711/integration-sdk-csharp/compare/main...tone711-patch-1