dev-billy commented 2 years ago

Added an edit text mask, which helps in inputting numbers with standardized formats.

example:

Inputting a phone number with format +255(0)XXX-XXXXXX
Inputting a passport number

This fix helps to define the mask on a new input field

codecov[bot] commented 2 years ago

Codecov Report

Merging #116 (9955c6f) into master (dd3f158) will increase coverage by 0.07%. The diff coverage is 76.08%.

@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
+ Coverage     74.91%   74.98%   +0.07%     
- Complexity      425      454      +29     
============================================
  Files            41       43       +2     
  Lines          1443     1535      +92     
  Branches        321      346      +25     
============================================
+ Hits           1081     1151      +70     
- Misses          115      121       +6     
- Partials        247      263      +16

Impacted Files	Coverage Δ
...java/com/nerdstone/neatformcore/utils/Constants.kt	`0.00% <ø> (ø)`
...core/views/handlers/ViewVisibilityChangeHandler.kt	`60.00% <0.00%> (-15.00%)`	:arrow_down:
...rmcore/views/builders/MaskedEditTextViewBuilder.kt	`63.26% <63.26%> (ø)`
...tformcore/views/widgets/MaskedEditTextNFormView.kt	`95.00% <95.00%> (ø)`
...erdstone/neatformcore/form/json/JsonFormBuilder.kt	`80.45% <100.00%> (+0.22%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd3f158...9955c6f. Read the comment docs.

cozej4 commented 2 years ago

Hi @ellykits. Could you check this implementation and review the PR. This is a nice addition to the neat forms

ellykits commented 2 years ago

Noted @cozej4 I have been away for vacation but will resume soon.

ellykits commented 2 years ago

:+1: LGTM squash merge your changes. Thanks for the contribution @dev-billy

dev-billy commented 2 years ago

Great, Thank you. Would love to get write access so I can squash merge the changes @ellykits

ellykits commented 2 years ago

I have merged the code.

On Sat, Mar 5, 2022 at 7:39 PM Billy @.***> wrote:

Great, Thank you. Would love to get write access so I can squash merge the changes @ellykits https://github.com/ellykits

— Reply to this email directly, view it on GitHub https://github.com/ellykits/neat-form/pull/116#issuecomment-1059793784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGM667EL6Z5EQ47LLEHUSZDU6OE5JANCNFSM5PD2DEPA . You are receiving this because you were mentioned.Message ID: @.***>

ellykits commented 2 years ago

Also sent you an invite as a collaborator

On Sat, Mar 5, 2022 at 7:44 PM Elly Kits @.***> wrote:

I have merged the code.

On Sat, Mar 5, 2022 at 7:39 PM Billy @.***> wrote:

Great, Thank you. Would love to get write access so I can squash merge the changes @ellykits https://github.com/ellykits

— Reply to this email directly, view it on GitHub https://github.com/ellykits/neat-form/pull/116#issuecomment-1059793784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGM667EL6Z5EQ47LLEHUSZDU6OE5JANCNFSM5PD2DEPA . You are receiving this because you were mentioned.Message ID: @.***>

dev-billy commented 2 years ago

Great👍🏾
Thanks

ellykits / neat-form

Implementing edit text mask #116

Codecov Report