ellykits / neat-form

Build form on Android using JSON schema; also includes view validation and skip logic.
Apache License 2.0
67 stars 28 forks source link

Issue 76 : Implement passing of custom checkbox attributes via custom xml form layout #77

Closed cozej4 closed 4 years ago

cozej4 commented 4 years ago

Implement passing of custom checkbox attributes via custom xml form layout

codecov[bot] commented 4 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.57%. The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     72.67%   73.25%   +0.57%     
- Complexity      373      378       +5     
============================================
  Files            36       36              
  Lines          1153     1129      -24     
  Branches        232      230       -2     
============================================
- Hits            838      827      -11     
+ Misses          144      133      -11     
+ Partials        171      169       -2
Impacted Files Coverage Δ Complexity Δ
...neatformcore/views/builders/CheckBoxViewBuilder.kt 75% <0%> (ø) 6 <0> (ø) :arrow_down:
...erdstone/neatformcore/form/json/JsonFormBuilder.kt 54.47% <100%> (+0.4%) 20 <0> (ø) :arrow_down:
...ne/neatformcore/views/widgets/CheckBoxNFormView.kt 88.46% <100%> (+7.5%) 14 <0> (-2) :arrow_down:
...e/views/builders/MultiChoiceCheckBoxViewBuilder.kt 75% <50%> (+1.92%) 20 <0> (ø) :arrow_down:
...atformcore/views/containers/MultiChoiceCheckBox.kt 73.68% <66.66%> (-1.93%) 13 <0> (ø)
...a/com/nerdstone/neatformcore/rules/RulesFactory.kt 77.41% <0%> (+3.22%) 29% <0%> (+4%) :arrow_up:
.../nerdstone/neatformcore/rules/NFormRulesHandler.kt 53.84% <0%> (+5.12%) 17% <0%> (+2%) :arrow_up:
...tone/neatformcore/views/handlers/ViewDispatcher.kt 72.22% <0%> (+5.55%) 6% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0ebe1d...ba9f9f9. Read the comment docs.