search

ellykits / neat-form

Build form on Android using JSON schema; also includes view validation and skip logic.
Apache License 2.0
67 stars 28 forks source link

Updated forms to recreate the rule engine bug #92

Closed cozej4 closed 4 years ago

cozej4 commented 4 years ago

Rule Engine bug

codecov[bot] commented 4 years ago

Codecov Report

Merging #92 into master will increase coverage by 0.03%. The diff coverage is 65.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     73.65%   73.68%   +0.03%     
- Complexity      407      443      +36     
============================================
  Files            38       40       +2     
  Lines          1298     1425     +127     
  Branches        270      313      +43     
============================================
+ Hits            956     1050      +94     
+ Misses          149      137      -12     
- Partials        193      238      +45
Impacted Files Coverage Δ Complexity Δ
...ava/com/nerdstone/neatformcore/utils/Extensions.kt 81.81% <ø> (-7.08%) 0.00 <0.00> (ø)
...n/java/com/nerdstone/neatformcore/utils/Helpers.kt 83.33% <ø> (+50.00%) 0.00 <0.00> (ø)
...core/views/handlers/ViewVisibilityChangeHandler.kt 75.00% <0.00%> (-12.50%) 3.00 <0.00> (+1.00) :arrow_down:
...eatformcore/views/widgets/NotificationNFormView.kt 73.68% <33.33%> (-8.67%) 8.00 <1.00> (ø)
...rmcore/views/builders/NumberSelectorViewBuilder.kt 65.06% <47.45%> (-7.16%) 37.00 <9.00> (+4.00) :arrow_down:
...erdstone/neatformcore/form/json/JsonFormStepper.kt 49.20% <49.20%> (ø) 4.00 <4.00> (?)
...rdstone/neatformcore/domain/model/NFormViewData.kt 60.00% <50.00%> (+10.00%) 2.00 <0.00> (+1.00)
...com/nerdstone/neatformcore/form/json/JsonParser.kt 50.00% <50.00%> (ø) 1.00 <1.00> (?)
.../nerdstone/neatformcore/viewmodel/DataViewModel.kt 60.00% <50.00%> (-40.00%) 4.00 <3.00> (+3.00) :arrow_down:
...tone/neatformcore/views/handlers/ViewDispatcher.kt 57.14% <57.14%> (-14.29%) 4.00 <4.00> (-3.00)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8d9f4e...222824b. Read the comment docs.