search

elm-community / elm-webgl

Moved to elm-explorations/webgl
http://package.elm-lang.org/packages/elm-explorations/webgl/latest
BSD 3-Clause "New" or "Revised" License
95 stars 22 forks source link

Implement native toHtml #14

Closed w0rm closed 8 years ago

w0rm commented 8 years ago

Quickly updated the native module to depend only on elm-lang/html and made all examples work.

I also tried it with elm-street-404 and it worked fine.

Please review carefully.

UPDATE: using it for elm-mogee now.

Apanatshka commented 8 years ago

I cannot evaluate the JS part of this PR because I don't know enough about that stuff. But it doesn't crazy and the Elm part looks good to me.

w0rm commented 8 years ago

@eeue56 when do you have time to check this? I'm really looking forward to migrate my games to 0.17 and the current elm-webgl is broken for me.

eeue56 commented 8 years ago

@w0rm I had a look through the other day and there some bits that I'm unsure about. It looks okay to merge for now though. Do you want to handle that + publishing?

w0rm commented 8 years ago

@eeue56 sure, I'll be happy to do whatever it takes for it to get published.

If you have any concerns, please let me know.

w0rm commented 8 years ago

@eeue56 I don't have access to do anything about it :)

eeue56 commented 8 years ago

I've invited you, but please bear this in mind -> https://github.com/elm-community/elm-webgl/blob/master/CONTRIBUTING.md#contributing-to-elm-communityelm-webgl