elm-community / guidelines

guidelines for *-extra contributors
33 stars 24 forks source link

Adopt canadaduane/typed-svg? #69

Closed canadaduane closed 7 years ago

canadaduane commented 7 years ago

Leaving this here as a discussion point per Noah's request, so I can point interested parties here.

TypedSvg is an attempt to replace the elm-lang/svg package with a fully typed (and documented) equivalent. Some reasonable module separation has been included (for instance, to keep filters in their own modules, and my intent was to move animations to their own module as well). In addition, there are some convenience modules that help with common things like unit lengths (InPx, InEm) so that specifying the unit on every call is unnecessary.

I'd be happy if elm-community decided to adopt this, as I will be moving on from Elm.

https://github.com/canadaduane/typed-svg

eeue56 commented 7 years ago

Needs someone to step forward as maintainer

rupertlssmith commented 7 years ago

Happy to be the maintainer. I'll be using this library a lot in the coming months so I have an interest in looking after it. Also, many thanks to Duane for getting it this far.

eeue56 commented 7 years ago

Are you familiar with how to publish a package?

mgold commented 7 years ago

In case you're not.

rupertlssmith commented 7 years ago

Yes.

avh4 commented 7 years ago

FYI, I'd be happy to help review PRs for typed-svg (though wouldn't have time for active development).

@rupertlssmith, since you're stepping up, feel free to ping me if you ever need an extra hand.

eeue56 commented 7 years ago

@rupertlssmith Please open a like this

@canadaduane Please transfer typed-svg to me. Thanks for your work on it, it's in good hands!

canadaduane commented 7 years ago

Transferred. Thanks all!

rupertlssmith commented 7 years ago

Hopefully, this is what you meant:

https://github.com/elm-community/Manifesto/issues/70

eeue56 commented 7 years ago

@canadaduane Please fork it back to your account -- right now, nobody can install typed-svg from you. That's my bad, I should've said. I'll make a checklist to make this easier in future.

gampleman commented 7 years ago

FYI, I'd be happy to help review PRs for typed-svg (though wouldn't have time for active development).

Same here.

canadaduane commented 7 years ago

Forked.