Why not use Result from core?

elm-community / parser-combinators

A parser combinator library for Elm.

http://package.elm-lang.org/packages/elm-community/parser-combinators/latest

BSD 3-Clause "New" or "Revised" License

104 stars 13 forks source link

Why not use Result from core? #5

Closed igrep closed 8 years ago

igrep commented 8 years ago

Why is the type Combine.Result defined as

type Result res
  = Done res
  | Fail (List String)

instead of

type alias Result res = Result.Result (List String) res

using the Result.Result from the core even though they are obviously isomorphic? It's annoying to convert every time calling parse!

Bogdanp commented 8 years ago

I'll make this change in the coming weeks. The reason I went with a new ADT initially is because I thought I would end up creating more result states that just those two.