search

elm-explorations / benchmark

BSD 3-Clause "New" or "Revised" License
26 stars 4 forks source link

Update README and Makefile for elm 19 #13

Closed harrysarson closed 5 years ago

harrysarson commented 5 years ago

Hi, I noticed some parts of the README still reference BrianHicks/elm-benchmark so I went ahead and updated all these references to now point to elm-explorations/benchmark. I also updated things like elm-package to be consistent with elm 19.

I also had a go at updating the Makefile to work with elm 19, I made some progress here and formatting, docs and flow now all work. However, elm refuses to build the tests or the examples due to the presence of kernel code.

As neither neither tests nor examples are running the CI fails - https://travis-ci.com/harrysarson/benchmark/builds/93493214.

BrianHicks commented 5 years ago

this is wonderful! Thank you for doing this work! I don't have time to review this week, but I will next. Expect to hear from me then. 😄

harrysarson commented 5 years ago

May I give a friendly ping here?

BrianHicks commented 5 years ago

yep! I know I gave a specific timeframe but it turns out that was a mistake. Sorry!

I got buried under a lot of other work and am currently digging my way out. Rest assured I haven't given up on this. Thank you again for sending it in. ❤️

harrysarson commented 5 years ago

I understand completely, wishing you a happy new year :)