elm-explorations / test

Write unit and fuzz tests for Elm code.
https://package.elm-lang.org/packages/elm-explorations/test/latest
BSD 3-Clause "New" or "Revised" License
237 stars 39 forks source link

Link to appveyor.yml is broken #150

Closed marciofrayze closed 1 year ago

marciofrayze commented 4 years ago

At "Running tests on CI" topic, this link is broken:

https://github.com/rtfeldman/elm-css/blob/master/appveyor.yml

harrysarson commented 4 years ago

See https://github.com/rtfeldman/elm-css/commit/aa6e23178f74b640aae7fc297749b5c1477d501c#diff-180360612c6b8c4ed830919bbb4dd459

Anton-4 commented 4 years ago

Ok if I submit a PR to fix this in the README? I think it would also be valuable to add a link for github actions ci, like here in dillonkearns/elm-cli-options-parser.

harrysarson commented 4 years ago

This dillonkearns/elm-cli-options-parser config file is huge! I would love to see a much simpler config we can link to (unless that really is the minimum configuration you need to run elm-test test using github actions).

Anton-4 commented 4 years ago

True, I will make and test a minimal version.

Anton-4 commented 4 years ago

This is a minimal config:

name: Elm Actions

on:
  push:
    branches:
      - master
  pull_request:
    branches:
      - master

jobs:
  test:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: 14
      - run: npm clean-install
      - name: elm-test
        run: npx --no-install elm-test

Should I save it as a gist, update the readme and submit a PR?

harrysarson commented 4 years ago

Could you make a PR to fairly mainstream elm package adding this configuration to their CI? I think it would be nice to link to an actual CI set up.

If elm-css is merging PR's at the moment it might be a good package to go for.

Anton-4 commented 4 years ago

elm-css is already the linked travis example in the readme, so if I were to change the ci conf for it, another travis example should be linked if you want to link an actively used conf. It also uses elm-format which would benefit greatly from caching, and so would blow up the conf file size.

Is elm-hex a good candidate? Would you like a mainstream often used package or a mainstream regularly updated package? Most regularly updated packages use elm-format.

harrysarson commented 4 years ago

Especially because github actions allows publishing actions I am reluctant to ask folk to copy in a massive configuration file. If caching is helpful, then maybe someone should publish a github action for elm that makes caching simple to configure. Then we could include it in the config we recommend. How does that sound? I may be slightly confused here.

Anton-4 commented 4 years ago

I've been thinking the same thing :), I'll look into it tomorrow!

Anton-4 commented 4 years ago

I didn't get to it today, I'll do it next week.

Anton-4 commented 4 years ago

I've started working on this. It may take some time, I'd like it to be the complete package for elm continuous integration with support for elm-test, -format, -review, -analyse and publishing.

lydell commented 1 year ago

Does this issue refer to documentation that does not exist anymore?

Janiczek commented 1 year ago

The CI documentation was removed in bdd14b8fa1ab56cb31b3e6d2206bbdb8bb062b5e - closing