search

elm-explorations / test

Write unit and fuzz tests for Elm code.
https://package.elm-lang.org/packages/elm-explorations/test/latest
BSD 3-Clause "New" or "Revised" License
236 stars 40 forks source link

Add missing imports in documentation #233

Open jfmengels opened 6 months ago

jfmengels commented 6 months ago

I've noticed a few missing imports in the examples.

A few notes: The imports are not sorted the way that elm-format sorts them. Would you like to see this be done as well?

I've only done it for this module, but I've seen some examples in Test.Html.Query where imports are missing and/or lead to confusion and invalid code. (See for instance Test.Html.Query.keep where text is used from both Html and Test.Html.Selector, and similarly Test.Html.Query.children uses class in the same invalid way). Let me know if you want me to solve this (and if so, indicate how you would prefer to see these collisions resolved). Maybe other modules have import issues, I haven't looked at it yet.

Janiczek commented 6 months ago

Thanks Jeroen!

The imports are not sorted the way that elm-format sorts them. Would you like to see this be done as well?

Yeah that would be nice!

Janiczek commented 6 months ago

Let's keep Test.Html.Query for some other day :+1: