Open MartinSStewart opened 1 year ago
@MartinSStewart i investigated this, seems that inconsistent behavior is because the depth buffer is disabled in toHtmlWith
, but the depth test is performed by the entity
.
I wonder what should be the result of a depth test if there is no depth buffer ? Perhaps different browsers interpret this differently
Yeah, it seems like it's browser specific (hence why I get difference results on Chrome and Firefox). I think the solution to this would be to make sure whatever happens, it's consistent between browsers?
I am not sure how important is to fix browser inconsistencies in the case of misconfiguration. Perhaps the documentation could be better to prevent this? The somethingWith
functions are meant for advanced usage where it may be ok to assume folks know what they are doing.
Alternatively maybe the WebGL API could be changed to prevent this. Maybe different versions of toHtml
that pass down something similar to the Key
from elm/browser, that is necessary to create the depth test or stencil test settings for entities. This would complicate the API quite a bit.
Or the implementation — if there is an entity with the depth test in the list of entities — the depth buffer is getting automatically turned on. This can only happen on the first render though. Doing this implicitly may be a bit weird.
Maybe a phantom type could be used to prevent the misconfiguration? Adding a stencil/depth check to an entity forces it to have a specific extension record as a phantom type (i.e. { a | needsStencil : (), needsDepth : () }
) and then the option to add that must be included in WebGL.withHtml
.
The following code (Ellie link) will show a green rectangle on Firefox and a black rectangle on Chrome and Safari. This behavior is consistent both on Windows and Mac OS.
If you change
WebGL.entity
toWebGL.entityWith []
then all browsers will be consistent in showing a green rectangle.