Closed rundis closed 7 years ago
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
Isn't this just a duplicate of https://github.com/elm-lang/elm-make/issues/106 ?
This is disallowed in the upcoming version of things.
https://github.com/elm-lang/elm-compiler/blob/dev/src/Elm/Package.hs#L128-L129
Context:
Github allows dots in repository names so something like
product.dufus
is valid. However if you specifyhttps://github.com/user/project.dufus.git
in the repository field of elm-package.json you will get a runtime error from the generated js.Steps to reproduce
Workarounds
Don't use dot's in repository names in elm-package.json
Discussion
For packages it's probably not a great idea to have dots in the name, but for end-user projects I don't see why this shouldn't be supported. If the decision is not support, an error message at an earlier stage would be nice.