elm-lang / elm-package

Command line tool to share Elm libraries
BSD 3-Clause "New" or "Revised" License
213 stars 66 forks source link

"Okay, I did not change anything!" still writes elm-package.json #278

Open drathier opened 7 years ago

drathier commented 7 years ago

If you run elm-make for the first time, and don't approve of the upgrade plan, it claims that it didn't change anything, but It still writes the template elm-package.json.

https://github.com/elm-lang/elm-package/blob/1a364bccd08f2859f8572d63c2ad5029b6c70ffe/src/Install.hs#L78

drathier@dratq MINGW64 ~
$ mkdir test

drathier@dratq MINGW64 ~
$ cd test

drathier@dratq MINGW64 ~/test (master)
$ elm-make
Some new packages are needed. Here is the upgrade plan.

  Install:
    elm-lang/core 5.1.1
    elm-lang/html 2.0.0
    elm-lang/virtual-dom 2.0.4

Do you approve of this plan? [Y/n] n
Could not find package elm-lang/core.

Maybe your elm-stuff/ directory has been corrupted? You can usually fix stuff
like this by deleting elm-stuff/ and rebuilding your project.
Okay, I did not change anything!

drathier@dratq MINGW64 ~/test (master)
$ ls
elm-package.json

drathier@dratq MINGW64 ~/test (master)
$ cat elm-package.json
{
    "version": "1.0.0",
    "summary": "helpful summary of your project, less than 80 characters",
    "repository": "https://github.com/user/project.git",
    "license": "BSD3",
    "source-directories": [
        "."
    ],
    "exposed-modules": [],
    "dependencies": {
        "elm-lang/core": "5.1.1 <= v < 6.0.0",
        "elm-lang/html": "2.0.0 <= v < 3.0.0"
    },
    "elm-version": "0.18.0 <= v < 0.19.0"
}
process-bot commented 7 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

ggPeti commented 6 years ago

+1, there's nothing more annoying than lying programs.