Update github fetch to change zipball -> legacy.zip

elm-lang / elm-package

Command line tool to share Elm libraries

BSD 3-Clause "New" or "Revised" License

213 stars 66 forks source link

Update github fetch to change zipball -> legacy.zip #285

Closed jxbadam closed 6 years ago

jxbadam commented 6 years ago

github has changed zipball to legacy.zip in URLs.

process-bot commented 6 years ago

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

evancz commented 6 years ago

The documentation says zipball is supported https://developer.github.com/v3/repos/contents/#get-archive-link (though the response says legacy.zip is the true endpoint)

Can you find links supporting your claim? GitHub seems to be recommending that I keep it as is.

jxbadam commented 6 years ago

@evancz I'm uncertain as I opened this PR many months ago. I'm reasonably sure this was in response to something that was being done breaking with a 404 or some such out of github.

If github has been updated or no one else is having the issue then we can just forget about it for now... it's here if you need it in the future. Closing out.