search

elm-lang / elm-package

Command line tool to share Elm libraries
BSD 3-Clause "New" or "Revised" License
213 stars 66 forks source link

correct function reference #286

Closed axelwathne closed 6 years ago

axelwathne commented 6 years ago

I came across this while brewing elm. I don't know what I am doing, but the change seems reasonable looking at it.

process-bot commented 6 years ago

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

axelwathne commented 6 years ago

The build failure looks unrelated to the change, "no rakefile found"

zwilias commented 6 years ago

It appears that libraryVersion isn't actually used anywhere. @evancz may prefer just removing it altogether.

ilovezfs commented 6 years ago

@evancz what is the status here?

axelwathne commented 6 years ago

Added the change from #287. Still "No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)", perhaps unsurprisingly

evancz commented 6 years ago

The code structure has changed a lot in preparation for 0.19, so I think it would have been long before this was initially opened that this code moved to a different repo.

I do not know what "brewing" means here, but there are many ways a Haskell build can fail. Since the development build now lives entirely in elm-lang/elm-compiler, I think it makes sense to close.

axelwathne commented 6 years ago

"brewing" here means building with homebrew (building and installing om Mac OS X) per this recipe: https://github.com/Homebrew/homebrew-core/blob/master/Formula/elm.rb - which has since had the patch applied to allow building.