search

elm-lang / elm-package

Command line tool to share Elm libraries
BSD 3-Clause "New" or "Revised" License
213 stars 66 forks source link

Paths.hs: fix build failure #287

Closed ilovezfs closed 6 years ago

ilovezfs commented 6 years ago

correct capitalization of versionToString

use Package.toFilePath not N.toFilePath since the import is import qualified Elm.Package as Package

Fixes some minor issues from https://github.com/elm-lang/elm-package/commit/955f7c92bfe7bce0672ca727fd41dc7b4a64b149#diff-1018d219b45fd14b9344475f2c1ddbd4

The build failure is

[ 1 of 27] Compiling Utils.Paths      ( src/Utils/Paths.hs, dist/dist-sandbox-abceb512/build/elm-package/elm-package-tmp/Utils/Paths.o )

src/Utils/Paths.hs:15:27: error:
    Not in scope: ‘N.toFilePath’
    No module named ‘N’ is imported.

src/Utils/Paths.hs:19:26: error:
    Not in scope: ‘Package.versiontoString’
    Perhaps you meant one of these:
      ‘Package.versionToString’ (imported from Elm.Package),
      ‘Package.versionFromString’ (imported from Elm.Package)
    Module ‘Elm.Package’ does not export ‘versiontoString’.

CC @evancz

process-bot commented 6 years ago

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

axelwathne commented 6 years ago

The versiontoString fix is the same as #286 - but I somehow didn't get the N.toFilePath error.

ilovezfs commented 6 years ago

@axelwathne ok. Feel free to incorporate that change into your PR. I will close this one out.