search

elm-lang / elm-reactor

Interactive development tool that makes it easy to develop and debug Elm programs.
BSD 3-Clause "New" or "Revised" License
428 stars 63 forks source link

Elm-Reactor can not find runElmProgram on page with JS module library (like requirejs) #227

Open AlexErofeev opened 7 years ago

AlexErofeev commented 7 years ago

In https://github.com/elm-lang/elm-make/issues/50 was added code to move Elm object from global scope if on the page any JS module library (requirejs, for example) is present. Nonetheless elm-reactor still assumes that Elm object is present in global scope. My propose is to add additional checks to function toJavaScript in file https://github.com/elm-lang/elm-reactor/blob/master/src/backend/Compile.hs

process-bot commented 7 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.