elm-lang / elm-reactor

Interactive development tool that makes it easy to develop and debug Elm programs.
BSD 3-Clause "New" or "Revised" License
428 stars 63 forks source link

elm-reactor silently fails if the repository field in elm-package.json contain dots in the URL path #237

Open feature opened 6 years ago

feature commented 6 years ago

Issue

When the repository field in your elm-package.json file contain dots in the URL path, elm-reactor will silently fail, and not display your app. I've made a project that you can find at the bottom of this issue, which demonstrates this issue.

For the time being my workaround is just stripping the dots from the URL path.

Example URLs

These URLs cause the issue:

Whereas these do not:

System details

OS: Arch Linux x86_64, version 4.9.75-1-lts elm & elm-reactor version: 0.18.0 Browser: Firefox Quantum, version 57.0.4

Steps to reproduce

Clone the repository linked below, and run it using elm-reactor and open the Main.elm file.

https://github.com/LilPepo/elm-reactor-bug-report

Edit

This also seems to affect elm-make. I'm not sure what other tools are also affected by this.

process-bot commented 6 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.